Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe inventory consistency between versions #425

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Conversation

zimeon
Copy link
Contributor

@zimeon zimeon commented Feb 18, 2020

Fixes #421

MUST represent the same object state as the corresponding version block in the current inventory file.
Additionally, the values of the <code>created</code>, <code>message</code> and <code>user</code> keys in
each version block in each prior inventory file SHOULD have the same values as the corresponding keys in
the correspodings version block in the current inventory file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this saying that it is possible to change the responsibility of previous versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in 'corresponding' L843

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, typo fixed.

This doesn't talk about change, just the state of different version inventories at any point in time. Having said that, I think of it as a rule going forward in time -- I SHOULD NOT change the v1 message in the v2 inventory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm asking why we're saying we "SHOULD NOT" change the message in v1 when it's referenced in the v2 inventory, instead of "MUST NOT". I would think that all versions of the v1 block in all inventories MUST be exactly the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that goes back to the question of #421 -- I prefer SHOULD because I can see legitimate reasons for an update yet one would want to ever rewrite the old version inventory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What legitimate reasons are there for updating the created, message, and user values of previous versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move discussion back up to #421...

@rosy1280 rosy1280 merged commit ccbf704 into master Mar 3, 2020
@rosy1280 rosy1280 deleted the issue-421 branch July 20, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we say anything about consistency or otherwise of version metadata between version inventories?
4 participants